Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service] Rename the ServiceId proto to Service #147

Closed
wants to merge 3 commits into from

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Nov 6, 2023

Summary

Renamed the ServiceId proto to Service so ServiceId.Id is more semantic and less confusing.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk self-assigned this Nov 6, 2023
@Olshansk Olshansk removed the request for review from bryanchriswhite November 6, 2023 20:57
@Olshansk Olshansk added the service Anything related to general-purpose RPC service support label Nov 6, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Nov 6, 2023
@Olshansk Olshansk marked this pull request as ready for review November 6, 2023 22:35
@Olshansk
Copy link
Member Author

Olshansk commented Nov 7, 2023

Closing in favor of #150

@Olshansk Olshansk closed this Nov 7, 2023
@Olshansk Olshansk deleted the issues/140/create_claim branch November 8, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service Anything related to general-purpose RPC service support
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant